-
Notifications
You must be signed in to change notification settings - Fork 33
jenkins: Add jenkins jobs for machine type Q35 #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are the configs for the jenkins jobs for machine type Q35. Fixes kata-containers#143 Signed-off-by: Gabriela Cervantes <[email protected]>
jodh-intel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you add an explanation into the commit as to why CentOS was chosen? it wfm, but it would be useful to state why (even if that's just "we randomly decided to do this on CentOS" :)
|
I'm going to have a stab/guess that maybe CentOS was chosen to get some more/broader coverage in our 'CI test matrix'. Which, brings to my mind, @chavafg - maybe we should have the CI test matrix drawn out in a doc somewhere (obvious) on here - to show what combinations of things (rootfs, image, vsock, network, distros, hypervisors) we test, and using which CI jobs. I guess that could be a large/complex table, but maybe that is the point - to show/document the complexity and coverage. It may also help us understand if all repos are treated equal (as I'm pretty sure they are not, and that is probably deliberate right now). Taking a peek at Jenkins, and choosing what is probably the most complex case (runtime), and only PR builds, I see maybe 11 PR jobs for the runtime. wdyt? |
|
Agreed - such a doc would be very useful. In fact, why not make it a YAML document so it's human- and machine-readable and can be treated like a database? |
|
Personally I was thinking of a nicely human readable table in a markdown doc on this repo front page - something immediately accessible to human eyes. We sort of already have the info in a machine readable way if we need - sure, it's all in jenkins config xml files, and maybe you can pull it from a REST interface on the jenkins server itself... |
chavafg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GabyCT these jobs were renamed from the original centos jobs, please add the deletions of those here please.
|
We've got precedent for both approaches as we have a number of yaml dbs including the versions database. But we also have tables like https://github.com/kata-containers/osbuilder/#platform-distro-compatibility-matrix. Regarding turning yaml into a table, that should be easy as it would be a tweak to the golang tool on kata-containers/tests#1466. We can start simple with a table in the README, but we should "define one and once only" - I hate out-of-date docs ;) Unfortunately, I think we're going to have that table go stale as we add/remove XML files. We might be able to detect that by:
|
|
@grahamwhaley @jodh-intel opened #145 to track that task |
8d32e7b to
14d7a0a
Compare
|
@chavafg changes applied |
These are the configs for the jenkins jobs for machine type Q35.
Fixes #143
Signed-off-by: Gabriela Cervantes [email protected]