Conversation
june-fastly
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some CI runs failed where saving a cached asset failed, but that job is still marked as successful. That was hard to find, subsequent actions then fail to fetch the asset because it isn't in cache.
Annoyingly those subsequent actions then also successfully failed to fetch from cache, and continued executing their steps. Which then failed for mysterious reasons. I thought that was a dependency error, but it wasn't.
I can't see how to get GHA to fail the "save to cache" action when for some reason that fails. But I can make the "restore from cache" actions fail explicitly. I've separated these out from the other cache stuff, and also updated to @v5 while I'm here.