Skip to content

Conversation

clinton-encord
Copy link
Contributor

Short description

Resolves #4159

Implementation details

  • When region reaches the edge of the container, we autoScroll to bring it into view. This creates the effect where by leaving it at the edge will scroll the container.
  • The draggable function also has to know about wavesurfer then to get the current scroll value.

How to test it

  • Set up wavesurfer, and zoom in such that its
  • Create/update/drag regions to the edge of the container

Screenshots

Video available in the discussion.

Checklist

  • This PR is covered by e2e tests
  • It introduces no breaking API changes

@clinton-encord
Copy link
Contributor Author

@katspaugh from the discussion from the last PR (which I closed because that PR was made against my fork's main branch instead of a feature branch), I've made the feature work without introducing wavesurfer into draggable, which makes a lot of sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant