Skip to content

fix: remove duplicate @typescript-eslint/parser dependency#4244

Merged
katspaugh merged 1 commit intokatspaugh:mainfrom
davidpoblador:fix/remove-duplicate-eslint-parser
Nov 17, 2025
Merged

fix: remove duplicate @typescript-eslint/parser dependency#4244
katspaugh merged 1 commit intokatspaugh:mainfrom
davidpoblador:fix/remove-duplicate-eslint-parser

Conversation

@davidpoblador
Copy link
Contributor

Summary

  • Removed duplicate @typescript-eslint/parser entry from devDependencies
  • The package.json contained two entries with different versions (^8.43.0 and ^8.18.0)
  • Kept the newer version (^8.43.0) and removed the duplicate entry

Having duplicate dependency entries causes issues when bundling wavesurfer in dependent projects, as it creates ambiguity about which version should be used.

The package.json file contained two entries for @typescript-eslint/parser with different versions (8.43.0 and 8.18.0), which creates ambiguity and causes issues when bundling wavesurfer in dependent projects. Removed the older duplicate entry (8.18.0) and kept the newer version (8.43.0).
Copilot AI review requested due to automatic review settings November 15, 2025 09:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a duplicate dependency issue in package.json by removing a redundant entry for @typescript-eslint/parser. The package had two conflicting versions declared (^8.18.0 and ^8.43.0), and this fix keeps only the newer version which matches the companion @typescript-eslint/eslint-plugin package.

Key Changes:

  • Removed duplicate @typescript-eslint/parser dependency entry with version ^8.18.0
  • Retained version ^8.43.0, maintaining consistency with @typescript-eslint/eslint-plugin

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Owner

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@katspaugh katspaugh merged commit 97a3ed9 into katspaugh:main Nov 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants