Skip to content

feat(renderer): add barMinHeight back#4249

Merged
katspaugh merged 1 commit intokatspaugh:mainfrom
Matthew-Smith:add-bar-min-height
Nov 25, 2025
Merged

feat(renderer): add barMinHeight back#4249
katspaugh merged 1 commit intokatspaugh:mainfrom
Matthew-Smith:add-bar-min-height

Conversation

@Matthew-Smith
Copy link
Contributor

@Matthew-Smith Matthew-Smith commented Nov 25, 2025

Short description

This PR adds the ability to have a minimum bar height for the wavesurfer options.

Resolves #4248

Implementation details

sets the totalHeight to minHeight or totalHeight depending on which is greater

How to test it

easiest to see on the basic test page. add

  barWidth: 2,
  barMinHeight: 30,

to the create config object.

Screenshots

Screen.Recording.2025-11-25.at.9.57.32.AM.mov
Screen.Recording.2025-11-25.at.9.53.21.AM.mov

Checklist

  • This PR is covered by e2e tests
  • It introduces no breaking API changes

Copy link
Owner

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@katspaugh katspaugh merged commit 2ceea1f into katspaugh:main Nov 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add back barMinHeight

2 participants