Fix race condition with autoCenter/autoScroll during loadBlob (#4187) #4260
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a race condition where autoScroll and autoCenter would sometimes cause the scroll position to jump to the beginning when loading a blob. The issue occurred when renderProgress was called while the audio data was still being loaded/decoded (duration temporarily 0 or invalid), which triggered scrollIntoView to scroll to position 0. The fix adds a guard to only call scrollIntoView when valid audio data exists with a duration > 0, preventing the race condition. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
katspaugh
force-pushed
the
fix/autoscroll-race-condition
branch
from
e7d1e70 to
cfc0a06
Compare
Deploying wavesurfer-js with
|
| Latest commit: |
cfc0a06
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://da6e5fcd.wavesurfer-js.pages.dev |
| Branch Preview URL: | https://fix-autoscroll-race-conditio.wavesurfer-js.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a race condition where autoScroll and autoCenter options could cause the waveform scroll position to jump to the beginning during audio blob loading.
Key Changes:
- Added a guard condition in
renderProgress()to prevent scroll operations during audio loading - Added metadata tracking for the bug fix in
.beads/issues.jsonl
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/renderer.ts | Added validation to check for valid audio data (existence and duration > 0) before calling scrollIntoView(), preventing race condition during loading |
| .beads/issues.jsonl | Added issue tracking metadata for the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4187 - Race condition where
autoScrollandautoCenterwould sometimes cause the scroll position to jump to the beginning when loading a blob.Root Cause
The issue occurred when
renderProgress()was called while audio data was still being loaded/decoded. During this time:scrollIntoView()would be called with an invalid progress value (often 0)Solution
Added a guard in
renderProgress()(src/renderer.ts:729) to only callscrollIntoView()when:autoScrollis enabledthis.audioDatais not null)this.audioData.duration > 0)This prevents the race condition by ensuring scroll operations only happen after audio is fully loaded.
Test Plan
The fix preserves the original user workaround behavior (temporarily disabling autoCenter/autoScroll), but eliminates the need for it.
🤖 Generated with Claude Code