Added cleanup of the dragToSeek dragStream#4275
Merged
katspaugh merged 2 commits intokatspaugh:mainfrom Jan 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
There was no cleanup of the dragStream when the dragToSeek option was set to false using setOptions. As such there was no way of toggling the dragToSeek behavior.
Originally, I was having a problem where dragToSeek and regions.enableDragSelection could no longer be enabled simultaneously as of v7.11.1 (#4225). While this PR does not fix that issue, it does provide a workaround by temporarily disabling dragToSeek when using regions.enableDragSelection.
Resolves
Implementation details
How to test it
I made some minor changes to the examples/regions.js file in order to test the interaction between dragToSeek and regions.enableDragSelection. Please let me know if you want me to include these changes.
Screenshots
Checklist