Take container padding into account for canvases#4279
Open
JanMisker wants to merge 1 commit intokatspaugh:mainfrom
Open
Take container padding into account for canvases#4279JanMisker wants to merge 1 commit intokatspaugh:mainfrom
JanMisker wants to merge 1 commit intokatspaugh:mainfrom
Conversation
… Cache this padding value and recalculate when resizing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtract padding from container width when calculating canvas widths. Cache this padding value and recalculate when resizing.
Short description
Resolves #3892
Implementation details
The padding is cached and re-calculated only when the container resizes.
How to test it
Screenshots
See #3892
Checklist