Open
Conversation
Now the app can: -Set the channel name and description -Set the notification subtext -Add a "Close" action to the notification, along with customizing the action text and icon Fixed bugs: -Icon is never used if it's in "drawable" rather than "mipmap" -Used "Compat" library to make backwards compatibility easier
Android notifications have a "how long ago was this notification set" timer. Now there's an option to turn that off (the default is true, so it's shown, matching current behavior).
I got the error message that "onactivate" does not exist with the latest HEAD Version. I therefore investigated and found out that since the on() function has been changed, I think this has been forgotten to also be changed in the Java file.
If you had two apps using this plugin running, clicking "Close" on a notification for one would close both.
Apply fix from katzer#419 (comment)
Remove Windows platcform from plugin.xml to allow install on cordova >9
JayceeZ
reviewed
Aug 24, 2020
|
|
||
| <config-file target="AndroidManifest.xml" parent="/manifest"> | ||
| <uses-permission android:name="android.permission.WAKE_LOCK" /> | ||
| <uses-permission android:name="android.permission.FOREGROUND_SERVICE" /> |
There was a problem hiding this comment.
Please align those indents with the rest of the files (use spaces)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the app can:
-Set the channel name and description
-Set the notification subtext
-Add a "Close" action to the notification, along with customizing the action text and icon
-Disable the "time since the notification started" text
Fixed bugs:
-Icon is never used if it's in "drawable" rather than "mipmap"
-Used "Compat" library to make backwards compatibility easier