Skip to content

Conversation

@blalor
Copy link

@blalor blalor commented Jan 28, 2014

Still rough, but I really think the EBS stuff should be part of the main package. :-)

dcarley and others added 9 commits April 13, 2012 07:53
It's no longer as simple as determining the instance architecture.
Especially as this is the arch of the host instance rather than the guest.

Most AMIs handle this with an init process on boot that checks the meta-data
service for the instance's block mappings.
Defaults to EBS. Falls back to S3. The only difference is the root
device - (hd0,0) for EBS and (hd0) for S3.

Reversed order of cfg and imgtemplate vars to match the real file.
Conflicts:
	ami_creator/ami_creator.py
No need/ability to see the "graphical" menu anywhere.
There's something weird going on with the root filesystem label.
ExtDiskMount prefixes fslabel with "_".  It's not clear why, but in
trying to solve some problems booting the AMI built with this image I
was frustrated by the inconsistency and wanted to make it a little
more transparent (although I didn't make it any less dumb).
Took some queues from Bashton's AMIs.
@katzj
Copy link
Owner

katzj commented Jan 29, 2014

I am game to do something along these lines and can take a closer look in the next couple of days. I've got some related stuff that I use @ stackdriver to do similar so likely worth seeing where the overlaps are and aren't.

(PS glad to see that more people find this useful!)

@blalor
Copy link
Author

blalor commented Jan 29, 2014

Ah, I thought your name sounded familiar. We met at the BosOps meetup in your office a few weeks ago. :-)

Really, there's very little here except for the changes to the grub config. I finished up a working script that will take a KS config, volume ID and block device path and registers an AMI. I still find kickstart configs to be something of a black art with a disappointingly long cycle time for iterating on changes. But this, coupled with Packer, should let me build AMIs and Vagrant boxes that are identical.

I'll add the script today. You probably don't want to merge this PR directly.

@sonarclouddev14
Copy link

🤖 Pull Request summary

Adds Docker build support and improves AMI creation workflow.

Docker integration: New dockerized build environment with CentOS 6 and Fedora 20 support to avoid host/target distribution conflicts
Enhanced boot configuration: Updates grub config to support both EBS and S3-backed instances with proper kernel parameters
AMI creation automation: Complete script for creating EBS-backed AMIs with HVM/paravirtual support and automatic snapshot management
Filesystem label fixes: Corrects filesystem labeling issues in the AMI creator core
Updated CentOS 6 kickstart: Enhanced configuration with cloud-init, security improvements, and better EC2 compatibility

Review focus: The bootloader configuration changes in _create_bootconfig() are critical for instance boot success. Verify the filesystem label handling in _get_fstab() and the removal of rpmUtils.arch dependency doesn't break functionality.

💬 Please send your feedback

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants