Skip to content

Make tkinter import fail-proof#390

Merged
kayjan merged 3 commits intomasterfrom
bugfix/import-tkinter
May 15, 2025
Merged

Make tkinter import fail-proof#390
kayjan merged 3 commits intomasterfrom
bugfix/import-tkinter

Conversation

@kayjan
Copy link
Owner

@kayjan kayjan commented May 15, 2025

Description

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels May 15, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 7394148 Previous: 13af6ee Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 16870.404923979528 iter/sec (stddev: 0.000006045621558088276) 18569.27453633331 iter/sec (stddev: 0.0000027783639644082962) 1.10
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 142.44106538307935 iter/sec (stddev: 0.006586462291007053) 175.51880088502307 iter/sec (stddev: 0.004595240119949579) 1.23
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 14.35601257222947 iter/sec (stddev: 0.000242750252956967) 14.440285077566795 iter/sec (stddev: 0.00021087366713057394) 1.01
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 85.35010547118677 iter/sec (stddev: 0.00021351478166518184) 88.57871261406052 iter/sec (stddev: 0.00027470667114279406) 1.04
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 25257.755394094995 iter/sec (stddev: 0.0000010244563049387933) 26622.33160978314 iter/sec (stddev: 0.0000030498222568033975) 1.05
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1914.5056444926759 iter/sec (stddev: 0.000027903635665986323) 1862.8587598248637 iter/sec (stddev: 0.00001914159269963225) 0.97
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 161.55088722498115 iter/sec (stddev: 0.00003561307948171352) 172.0968722624385 iter/sec (stddev: 0.00003796307816031788) 1.07
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 77.11431924843832 iter/sec (stddev: 0.006692309034371382) 86.56126044274978 iter/sec (stddev: 0.00518366800817316) 1.12

This comment was automatically generated by workflow using github-action-benchmark.

@kayjan
Copy link
Owner Author

kayjan commented May 15, 2025

Addresses #389

@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.tree.construct 100% 100% 0
bigtree.tree.export 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2987 / 2987) 100% (1148 / 1148) 0

@kayjan kayjan merged commit cca6a26 into master May 15, 2025
7 checks passed
@kayjan kayjan deleted the bugfix/import-tkinter branch May 15, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant