Fix printing tree with rich and attribute square brackets#437
Merged
Fix printing tree with rich and attribute square brackets#437
Conversation
kayjan
added
enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: c790bcc | Previous: 8388228 | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
18148.82032662862 iter/sec (stddev: 0.000008144173063590435) |
19436.742635225863 iter/sec (stddev: 0.000004555818280885923) |
1.07 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
381.5412335235318 iter/sec (stddev: 0.0001130180082088331) |
448.4495976284381 iter/sec (stddev: 0.000024616225530138462) |
1.18 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
14.520265812661492 iter/sec (stddev: 0.0001016145678581015) |
14.97408570128804 iter/sec (stddev: 0.000043731372435473505) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
86.3644849339564 iter/sec (stddev: 0.00017599491803982781) |
89.15020915173626 iter/sec (stddev: 0.00006457115277962691) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
40778.29452955869 iter/sec (stddev: 0.000004375364629464345) |
38260.74313866998 iter/sec (stddev: 0.0000012440129608271642) |
0.94 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions_config |
31971.915869531676 iter/sec (stddev: 0.000017817040276044458) |
31992.782428988936 iter/sec (stddev: 0.00001686329464904579) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
2978.6212438830853 iter/sec (stddev: 0.0000057510408722864205) |
2042.6257177430489 iter/sec (stddev: 0.00024979430928828944) |
0.69 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions_config |
2115.997501852248 iter/sec (stddev: 0.00019131983117605478) |
3146.0802121428155 iter/sec (stddev: 0.000005206922204612684) |
1.49 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
114.17126183637048 iter/sec (stddev: 0.006790786452285261) |
117.48180408042718 iter/sec (stddev: 0.006740445682054385) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions_config |
214.92554071209193 iter/sec (stddev: 0.0002799799906703591) |
264.9430952570594 iter/sec (stddev: 0.000006298624364730572) |
1.23 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
195.4709746566872 iter/sec (stddev: 0.0001231956082407536) |
206.88492978486792 iter/sec (stddev: 0.00030467993764428765) |
1.06 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions_config |
100.53674153423052 iter/sec (stddev: 0.007369978253150317) |
98.96815112855943 iter/sec (stddev: 0.00727041210292555) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Square brackets when displaying node attributes confused with rich formatting
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)