Pass listen => 1 to Plack::Test::test_psgi#31
Open
ilmari wants to merge 1 commit intokazeburo:masterfrom
Open
Conversation
This gets passed on to Test::TCP which asks the kernel for a free listening socket, avoiding the race conditions inherent in trying to find a free one manually. No need to bump the Plack::Test version dependency, since older versions will just ignore the parameter and keep working in the racy fashion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets passed on to Test::TCP which asks the kernel for a free
listening socket, avoiding the race conditions inherent in trying to
find a free one manually.
No need to bump the Plack::Test version dependency, since older versions
will just ignore the parameter and keep working in the racy fashion.