Skip to content

Conversation

@denisdrozdov
Copy link

USB camera might not support any specific of_node or devicetree (on Ubuntu for instance).

Drop Controller ID check for such cases

USB camera might not support any specific of_node or devicetree.
Drop Controller ID check for such cases

Signed-off-by: Denys Drozdov <[email protected]>
@kbingham
Copy link
Owner

This doesn't look too unreasonable, but it's hard to fully understand the context.

Have you hit specific errors with this? I run on Ubuntu and have not seen this. Can you clarify what hardware you are using, and what errors you hit?

Also - can you confirm what your camera name looks like when you apply this patch? (run cam --list)

For example mine reports:

1: 'Logitech BRIO' (_SB_.PCI0.GP13.XHC0.RHUB.PRT3-3.1:1.0-046d:085e)

Finally - to be able to merge any patch to libcamera it has to be 'Signed-off'.

For example, my signoff would be:

Signed-off-by: Kieran Bingham [email protected]

Please add an appropriate SoB at the bottom of your commit message. Ideally it should be posted to the libcamera-devel mailing list [email protected], but if you can't do that (with the correct SoB) I can forward that on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants