Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/.serena/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/cache
113 changes: 113 additions & 0 deletions backend/.serena/project.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
# the name by which the project can be referenced within Serena
project_name: "backend"


# list of languages for which language servers are started; choose from:
# al bash clojure cpp csharp
# csharp_omnisharp dart elixir elm erlang
# fortran fsharp go groovy haskell
# java julia kotlin lua markdown
# matlab nix pascal perl php
# php_phpactor powershell python python_jedi r
# rego ruby ruby_solargraph rust scala
# swift terraform toml typescript typescript_vts
# vue yaml zig
# (This list may be outdated. For the current list, see values of Language enum here:
# https://github.com/oraios/serena/blob/main/src/solidlsp/ls_config.py
# For some languages, there are alternative language servers, e.g. csharp_omnisharp, ruby_solargraph.)
# Note:
# - For C, use cpp
# - For JavaScript, use typescript
# - For Free Pascal/Lazarus, use pascal
# Special requirements:
# Some languages require additional setup/installations.
# See here for details: https://oraios.github.io/serena/01-about/020_programming-languages.html#language-servers
# When using multiple languages, the first language server that supports a given file will be used for that file.
# The first language is the default language and the respective language server will be used as a fallback.
# Note that when using the JetBrains backend, language servers are not used and this list is correspondingly ignored.
languages:
- go

# the encoding used by text files in the project
# For a list of possible encodings, see https://docs.python.org/3.11/library/codecs.html#standard-encodings
encoding: "utf-8"

# whether to use project's .gitignore files to ignore files
ignore_all_files_in_gitignore: true

# list of additional paths to ignore in this project.
# Same syntax as gitignore, so you can use * and **.
# Note: global ignored_paths from serena_config.yml are also applied additively.
ignored_paths: []

# whether the project is in read-only mode
# If set to true, all editing tools will be disabled and attempts to use them will result in an error
# Added on 2025-04-18
read_only: false

# list of tool names to exclude. We recommend not excluding any tools, see the readme for more details.
# Below is the complete list of tools for convenience.
# To make sure you have the latest list of tools, and to view their descriptions,
# execute `uv run scripts/print_tool_overview.py`.
#
# * `activate_project`: Activates a project by name.
# * `check_onboarding_performed`: Checks whether project onboarding was already performed.
# * `create_text_file`: Creates/overwrites a file in the project directory.
# * `delete_lines`: Deletes a range of lines within a file.
# * `delete_memory`: Deletes a memory from Serena's project-specific memory store.
# * `execute_shell_command`: Executes a shell command.
# * `find_referencing_code_snippets`: Finds code snippets in which the symbol at the given location is referenced.
# * `find_referencing_symbols`: Finds symbols that reference the symbol at the given location (optionally filtered by type).
# * `find_symbol`: Performs a global (or local) search for symbols with/containing a given name/substring (optionally filtered by type).
# * `get_current_config`: Prints the current configuration of the agent, including the active and available projects, tools, contexts, and modes.
# * `get_symbols_overview`: Gets an overview of the top-level symbols defined in a given file.
# * `initial_instructions`: Gets the initial instructions for the current project.
# Should only be used in settings where the system prompt cannot be set,
# e.g. in clients you have no control over, like Claude Desktop.
# * `insert_after_symbol`: Inserts content after the end of the definition of a given symbol.
# * `insert_at_line`: Inserts content at a given line in a file.
# * `insert_before_symbol`: Inserts content before the beginning of the definition of a given symbol.
# * `list_dir`: Lists files and directories in the given directory (optionally with recursion).
# * `list_memories`: Lists memories in Serena's project-specific memory store.
# * `onboarding`: Performs onboarding (identifying the project structure and essential tasks, e.g. for testing or building).
# * `prepare_for_new_conversation`: Provides instructions for preparing for a new conversation (in order to continue with the necessary context).
# * `read_file`: Reads a file within the project directory.
# * `read_memory`: Reads the memory with the given name from Serena's project-specific memory store.
# * `remove_project`: Removes a project from the Serena configuration.
# * `replace_lines`: Replaces a range of lines within a file with new content.
# * `replace_symbol_body`: Replaces the full definition of a symbol.
# * `restart_language_server`: Restarts the language server, may be necessary when edits not through Serena happen.
# * `search_for_pattern`: Performs a search for a pattern in the project.
# * `summarize_changes`: Provides instructions for summarizing the changes made to the codebase.
# * `switch_modes`: Activates modes by providing a list of their names
# * `think_about_collected_information`: Thinking tool for pondering the completeness of collected information.
# * `think_about_task_adherence`: Thinking tool for determining whether the agent is still on track with the current task.
# * `think_about_whether_you_are_done`: Thinking tool for determining whether the task is truly completed.
# * `write_memory`: Writes a named memory (for future reference) to Serena's project-specific memory store.
excluded_tools: []

# list of tools to include that would otherwise be disabled (particularly optional tools that are disabled by default)
included_optional_tools: []

# fixed set of tools to use as the base tool set (if non-empty), replacing Serena's default set of tools.
# This cannot be combined with non-empty excluded_tools or included_optional_tools.
fixed_tools: []

# list of mode names to that are always to be included in the set of active modes
# The full set of modes to be activated is base_modes + default_modes.
# If the setting is undefined, the base_modes from the global configuration (serena_config.yml) apply.
# Otherwise, this setting overrides the global configuration.
# Set this to [] to disable base modes for this project.
# Set this to a list of mode names to always include the respective modes for this project.
base_modes:

# list of mode names that are to be activated by default.
# The full set of modes to be activated is base_modes + default_modes.
# If the setting is undefined, the default_modes from the global configuration (serena_config.yml) apply.
# Otherwise, this overrides the setting from the global configuration (serena_config.yml).
# This setting can, in turn, be overridden by CLI parameters (--mode).
default_modes:

# initial prompt for the project. It will always be given to the LLM upon activating the project
# (contrary to the memories, which are loaded on demand).
initial_prompt: ""
29 changes: 29 additions & 0 deletions backend/controllers/hint_controller.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
package controllers

import (
"net/http"

"github.com/gin-gonic/gin"
"github.com/kc3hack/2026_team10/backend/services"
)

type IHintController interface {
GetHints(ctx *gin.Context)
}
Comment on lines +10 to +12
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POST /solo のハンドラ名が GetHints になっており、処理内容(ゲーム開始/ラウンド作成)と名前が一致していません。用途が伝わるように StartGame / CreateRound などの名前に揃えることを検討してください。

Copilot uses AI. Check for mistakes.

type HintController struct {
service services.IHintService
}

func NewHintController(service services.IHintService) IHintController {
return &HintController{service: service}
}

func (c *HintController) GetHints(ctx *gin.Context) {
result, err := c.service.GetHints()
if err != nil {
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

エラー発生時に err を一切利用せず固定メッセージだけ返しているため、サーバ側での原因追跡が困難です。少なくともサーバログへ err を出力する(あるいは gin.Context.Error で付与する)など、運用上追える形にしてください。

Suggested change
if err != nil {
if err != nil {
ctx.Error(err)

Copilot uses AI. Check for mistakes.
ctx.JSON(http.StatusInternalServerError, gin.H{"error": "Failed to get hints"})
return
}
ctx.JSON(http.StatusOK, gin.H{"result": result})
}
27 changes: 23 additions & 4 deletions backend/main.go
Original file line number Diff line number Diff line change
@@ -1,13 +1,32 @@
package main

import "github.com/gin-gonic/gin"
import (
"github.com/gin-gonic/gin"
"github.com/kc3hack/2026_team10/backend/controllers"
"github.com/kc3hack/2026_team10/backend/model"
"github.com/kc3hack/2026_team10/backend/repositories"
"github.com/kc3hack/2026_team10/backend/services"
)

func main() {
router := gin.Default()
router.GET("/ping", func(c *gin.Context) {
rounds := []model.Round{
{
ID: 1,
Answer: "お題",
Hints: []string{"ヒント1", "ヒント2", "ヒント3"},
},
}

hintRepository := repositories.NewHintMemoryRepository(rounds)
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main.go 側で rounds に固定のお題/ヒントを初期投入している一方、service 側でも同じ固定値を生成しているため、データ定義が二重化しています(また最初の POST /solo の採番が 2 から始まります)。初期データは repository のみで管理する/サービス側に寄せる等、どこが真実のソースかを一本化してください。

Suggested change
rounds := []model.Round{
{
ID: 1,
Answer: "お題",
Hints: []string{"ヒント1", "ヒント2", "ヒント3"},
},
}
hintRepository := repositories.NewHintMemoryRepository(rounds)
hintRepository := repositories.NewHintMemoryRepository([]model.Round{})

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@yone-al yone-al Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot
rounds := []model.Round{}

hintRepository := repositories.NewHintMemoryRepository(rounds)

これでどう?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot
rounds := []model.Round{}

hintRepository := repositories.NewHintMemoryRepository(rounds)

これでどう?

hintService := services.NewHintService(hintRepository)
hintController := controllers.NewHintController(hintService)

r := gin.Default()
r.GET("/ping", func(c *gin.Context) {
c.JSON(200, gin.H{
"message": "pong",
})
})
router.Run() // デフォルトで0.0.0.0:8080で待機します
r.POST("/solo", hintController.GetHints)
r.Run() // デフォルトで0.0.0.0:8080で待機します
}
12 changes: 12 additions & 0 deletions backend/model/hint.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package model

type Round struct {
ID int
Answer string
Hints []string
}

type StartGameResult struct {
ID int `json:"id"`
Hints []string `json:"hints"`
}
26 changes: 26 additions & 0 deletions backend/repositories/hint_repository.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package repositories

import "github.com/kc3hack/2026_team10/backend/model"

type IHintRepository interface {
CreateRound(answer string, hints []string) (*model.Round, error)
}

type HintMemoryRepository struct {
rounds []model.Round
}

func NewHintMemoryRepository(rounds []model.Round) IHintRepository {
return &HintMemoryRepository{rounds: rounds}
}

func (r *HintMemoryRepository) CreateRound(answer string, hints []string) (*model.Round, error) {
newID := len(r.rounds) + 1
round := model.Round{
ID: newID,
Answer: answer,
Hints: hints,
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newID を len(rounds)+1 で作ると、初期データの ID が連番でない/欠番がある場合に ID 衝突が起きます。既存の最大 ID を走査するか、ID 生成を別コンポーネントに寄せるなどして一意性を担保してください。

Copilot uses AI. Check for mistakes.
}
r.rounds = append(r.rounds, round)
return &round, nil
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HintMemoryRepository は Gin のハンドラから同時に呼ばれる可能性があり、rounds への append/len がデータレースになります(ID の重複や panic の原因)。mutex 等で保護するか、永続層に切り替えるなどしてスレッドセーフにしてください。

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CreateRound が返している *Round は、append した要素ではなくローカル変数 round のアドレスです。呼び出し側が返値を保持して更新するケース等で、リポジトリ内のデータと不整合になります。append 後のスライス要素(末尾)を指すポインタを返すようにしてください。

Suggested change
return &round, nil
return &r.rounds[len(r.rounds)-1], nil

Copilot uses AI. Check for mistakes.
}
39 changes: 39 additions & 0 deletions backend/services/hint_service.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
package services

import (
"errors"

"github.com/kc3hack/2026_team10/backend/model"
"github.com/kc3hack/2026_team10/backend/repositories"
)

type IHintService interface {
GetHints() (*model.StartGameResult, error)
}

type HintService struct {
repository repositories.IHintRepository
}

func NewHintService(repository repositories.IHintRepository) IHintService {
return &HintService{repository: repository}
}

func (s *HintService) GetHints() (*model.StartGameResult, error) {
// お題、ヒントを作成
answer := "お題"
hints := []string{"ヒント1", "ヒント2", "ヒント3"}

// データを保存
result, err := s.repository.CreateRound(answer, hints)
if err != nil {
return nil, errors.New("failed to save hint data")
}
Comment on lines +28 to +31
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repository.CreateRound の err を握りつぶして固定文言に置き換えているため、原因追跡が難しくなります。呼び出し元で扱えるように err をラップして返す(%w)など、元のエラー情報を保持してください。

Copilot uses AI. Check for mistakes.

// IDとヒントを返す
response := &model.StartGameResult{
ID: result.ID,
Hints: hints,
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レスポンスの Hints が repository から返された result.Hints ではなくローカル変数 hints を参照しています。将来 repository 側で加工/コピーした場合にレスポンスと保存内容がズレるので、返却値(result)由来のデータを使うようにしてください。

Suggested change
Hints: hints,
Hints: result.Hints,

Copilot uses AI. Check for mistakes.
}
return response, nil
}