Fix crash in PIF generation #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcieplak
force-pushed
the
topics/fix-gh-9067
branch
from
ad890c5 to
dc9f56b
Compare
pmattos
reviewed
Oct 3, 2025
| } | ||
| // For products with a main module, compare package identity and name | ||
| // (build triples are no longer used in the package graph) | ||
| guard let mainModule = mainModuleProduct.mainModule else { return false } |
There was a problem hiding this comment.
suggestion: I think we can move the guard to the top. For instance:
guard let mainModule = mainModuleProduct.mainModule else {
return mainModuleProduct.type == .executable &&
mainModuleProduct.modules.only?.type == .binary
}
...I also simplified the logic a bit :)
kcieplak
force-pushed
the
topics/fix-gh-9067
branch
5 times, most recently
from
ca63fb1 to
fec6d4e
Compare
Fix a crash when unwrapping an optional 'mainModule' of a module. In the case where a plugin has a dependency on a 'binaryTarget' there is no main module. This only presents itself when you have defined the binaryTarget as both a product and target. * Update method that determines plugin dependencies to handle binaryTarget types explicitly. * Add a PIF generation test that captures this behavior.
kcieplak
force-pushed
the
topics/fix-gh-9067
branch
from
fec6d4e to
921daeb
Compare
Based on Review. * Remove unwrapping and use the guarded mainModule variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a crash when unwrapping an optional 'mainModule' of a module.
In the case where a plugin has a dependency on a 'binaryTarget' there is no main module.
This only presents itself when you have defined the binaryTarget as
both a product and target.