Skip to content

POC: labels selector poc - failed #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

POC: labels selector poc - failed #32

wants to merge 2 commits into from

Conversation

@mjudeikis
Copy link

@mjudeikis mjudeikis commented Mar 2, 2025 •
edited
Loading

Summary

Related issue(s)

Fixes #

Quick and dirty attempt to #31

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 2, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Mar 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Mar 2, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Mar 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign embik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 2, 2025
mjudeikis
mjudeikis commented Mar 2, 2025
View reviewed changes
internal/sync/syncer_related.go
sourceObjs.SetAPIVersion("v1")
sourceObjs.SetKind(relRes.Kind)

// TODO: would need to handle replacer here as well to select right object.
Copy link
Author

@mjudeikis mjudeikis Mar 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where it get tricky. You want to be able to use projections, and I think only place where we can get it is from "owning object" to which this resource is related. So this might need some wiring in...

@mjudeikis mjudeikis closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mjudeikis @kcp-ci-bot