Skip to content

Conversation

@ntnn
Copy link
Member

@ntnn ntnn commented Jun 17, 2025

Summary

Build with the new and improved code-generator/v3

See #46 without the code-gen noise

Related issue(s)

Requires kcp-dev/code-generator#111
Closes #46

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 17, 2025
@ntnn ntnn force-pushed the update-code-gen branch 4 times, most recently from 69af9fb to a48cfee Compare June 17, 2025 23:24
@ntnn ntnn changed the title [WIP] ✨ Update to code-generator/v3 ✨ Update to code-generator/v3 Jun 17, 2025
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2025
@ntnn ntnn changed the title ✨ Update to code-generator/v3 [WIP] ✨ Update to code-generator/v3 Jun 18, 2025
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2025
@ntnn
Copy link
Member Author

ntnn commented Jun 18, 2025

Setting to WIP again - the kcp unit and integration tests are working fine but I'm getting reproducible errors in the e2e tests.

@ntnn ntnn force-pushed the update-code-gen branch 2 times, most recently from 0a6e0ca to 6da9f49 Compare July 1, 2025 09:47
ntnn added 5 commits July 7, 2025 09:47
@ntnn ntnn force-pushed the update-code-gen branch from 6da9f49 to b815681 Compare July 7, 2025 09:26
@ntnn ntnn changed the title [WIP] ✨ Update to code-generator/v3 ✨ Update to code-generator/v3 Jul 7, 2025
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2025
@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 38c2b6d8fa83412ed7d1ca98136dddb5b9cac9d9

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@kcp-ci-bot kcp-ci-bot merged commit decc4df into kcp-dev:kcp-1.32.3 Jul 7, 2025
8 of 9 checks passed
@ntnn ntnn deleted the update-code-gen branch July 7, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants