Add helm chart for init-agent#185
Conversation
On-behalf-of: @SAP christoph.mewes@sap.com
kcp-ci-bot
added
do-not-merge/work-in-progress
xrstf
changed the title
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
charts/init-agent/README.md
Outdated
| @@ -0,0 +1,78 @@ | |||
| # KCP Helm Chart - Init Agent | |||
There was a problem hiding this comment.
| # KCP Helm Chart - Init Agent | |
| # kcp Helm Chart - Init Agent |
| * `""` (default) – By default, the Helm chart will output the Deployment, ServiceAccount and RBAC to | ||
| run the Init Agent on a Kubernetes cluster. For this to work, you need to provide Helm with a | ||
| kubeconfig for that cluster. | ||
| * `configcluster` – In this mode, the Helm chart outputs the RBAC necessary for the agent to read | ||
| and process its `InitTarget` objects. This is meant to be installed into the workspace that is | ||
| configured via `.configWorkspace` when installing the chart in default mode (above). This needs | ||
| to be done once, using a kubeconfig for Helm that points to the config workspace of choice in | ||
| kcp. | ||
| * `wstcluster` – This mode outputs the necessary RBAC to read and initialize `WorkspaceTypes`. This | ||
| needs to be installed into each workspace where `WorkspaceType` objects exist that are referenced | ||
| by an `InitTarget`.For this to work, you need to provide Helm with a kubeconfig that points to | ||
| the effective workspace. |
There was a problem hiding this comment.
Wouldn't it be overall better to just make these three separate helm charts? Although I can see the benefit of using the exact same values.yaml and just overriding the target depending on where the built yamls land.
There was a problem hiding this comment.
Looking at the templates however e.g. wstcluster only relies on its own information and the name of the helm deployment.
I was thinking that with all three being in the same helm chart one could at least install them all into the same kcp workspace but that doesn't work either because the target can only be one.
There was a problem hiding this comment.
Hmm... I feel like having multiple charts just for the init-agent is .. idk, it feels excessive. When I imagine seeing three init-agent-... charts in the charts folder.. it doesn't spark joy in me.
I have no technical arguments besides my hope that one day the setup will be much simpler and then we don't have to retire 2 charts.
There was a problem hiding this comment.
Yeah I agree. TBH I don't feel strong either way, it's just an odd setup :D
But that's kinda what happens when one component interacts with ~three control planes.
There was a problem hiding this comment.
Maybe lets make target into targets so e.g. the kcp workspace could be used as the configcluster and workspacetype cluster? Or all three if there's something providing compute for the target kcp workspace (or syncs the workspacetype from the compute cluster to the workspace)
On-behalf-of: @SAP christoph.mewes@sap.com
|
LGTM label has been added. DetailsGit tree hash: e12631fa353aa3cd6f128f71ec5b05762945e40d |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
3 participants
This PR creates a new Helm chart to install init-agent.
This chart is special in a sense that it can output 3 different sets of manifests, based on the
targetvalue. This is so that you have just one chart toI've tested this chart in a kind-based cluster using the kcp-operator to provision stuff for me. There's a documentation PR @ kcp-dev/init-agent#6 that outlines the process.