Skip to content

[release-0.1] cherrypick #4: add --leader-election-namespace flag#8

Merged
kcp-ci-bot merged 1 commit intokcp-dev:release-0.1from
xrstf:cherrypick-le-flag-0.1
Feb 27, 2026
Merged

[release-0.1] cherrypick #4: add --leader-election-namespace flag#8
kcp-ci-bot merged 1 commit intokcp-dev:release-0.1from
xrstf:cherrypick-le-flag-0.1

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Feb 27, 2026

Summary

#7 accidentally targeted the main branch, when it should have targeted release-0.1.

What Type of PR Is This?

/kind cleanup

Release Notes

Add `--leader-election-namespace` flag

@kcp-ci-bot kcp-ci-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has signed the DCO. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2026
Copy link
Member

@ntnn ntnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 36f7dfa47b41377db00b7b584d8c8ecb63a6e5c8

@xrstf
Copy link
Contributor Author

xrstf commented Feb 27, 2026

/override pull-init-agent-test-e2e-kcp-0.27
/override pull-init-agent-test-e2e-kcp-0.28
/override pull-init-agent-test-e2e-kcp-0.29

These tests were defined as ProwJobs in the initial commit, but only later in #2 actually implemented. The 0.1 release branch does not have such tests. I never expecte to open a release branch this early, and now it's biting me a bit in the rear end 😬

@kcp-ci-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-init-agent-test-e2e-kcp-0.27, pull-init-agent-test-e2e-kcp-0.28, pull-init-agent-test-e2e-kcp-0.29

Details

In response to this:

/override pull-init-agent-test-e2e-kcp-0.27
/override pull-init-agent-test-e2e-kcp-0.28
/override pull-init-agent-test-e2e-kcp-0.29

These tests were defined as ProwJobs in the initial commit, but only later in #2 actually implemented. The 0.1 release branch does not have such tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xrstf
Copy link
Contributor Author

xrstf commented Feb 27, 2026

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2026
@kcp-ci-bot kcp-ci-bot merged commit ab51012 into kcp-dev:release-0.1 Feb 27, 2026
12 checks passed
@xrstf xrstf deleted the cherrypick-le-flag-0.1 branch February 27, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants