add kcp operator custom metrics#121
Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom Jan 2, 2026
Merged
Conversation
kcp-ci-bot
added
release-note
olamilekan000
requested review from
embik and
mjudeikis
and removed request for
mjudeikis
olamilekan000
force-pushed
the
add-custom-kcp-operator-metrics
branch
from
62caaa4 to
a282340
Compare
mjudeikis
reviewed
Oct 24, 2025
|
|
||
| func (mc *MetricsCollector) updateRootShardCounts(ctx context.Context) { | ||
| var rootShards operatorv1alpha1.RootShardList | ||
| if err := mc.client.List(ctx, &rootShards); err != nil { |
Contributor
There was a problem hiding this comment.
Can we use cache (all below too) here?
Contributor
Author
There was a problem hiding this comment.
We might not get the actual metric values if they're cached, and besides, I think the Controller-runtime already implements caching by default
olamilekan000
force-pushed
the
add-custom-kcp-operator-metrics
branch
6 times, most recently
from
9886ccb to
8c170fc
Compare
olamilekan000
force-pushed
the
add-custom-kcp-operator-metrics
branch
from
8c170fc to
d5ce156
Compare
Contributor
Author
|
/retest |
mjudeikis
reviewed
Nov 5, 2025
Contributor
mjudeikis
left a comment
mjudeikis
left a comment
There was a problem hiding this comment.
still same few comments
Signed-off-by: olalekan odukoya <odukoyaonline@gmail.com>
olamilekan000
force-pushed
the
add-custom-kcp-operator-metrics
branch
from
d5ce156 to
903116d
Compare
Contributor
|
LGTM label has been added. DetailsGit tree hash: 4f4f8f3cadadc93aa319dc98460174b8956b740e |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
mjudeikis
added
the
kind/feature
kcp-ci-bot
removed
the
do-not-merge/needs-kind
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes 25
Release Notes