Skip to content

Implement cache servers#144

Merged
kcp-ci-bot merged 17 commits intokcp-dev:mainfrom
xrstf:implement-cache-servers
Feb 12, 2026
Merged

Implement cache servers#144
kcp-ci-bot merged 17 commits intokcp-dev:mainfrom
xrstf:implement-cache-servers

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Feb 2, 2026

Summary

This PR implements support for creating and reconciling a kcp cache server. It offers to the user what kcp currently offers to us: A singular cache server that cannot have meaningful persistence yet.

  • Singular: kcp only allows to configure one single cache serve using --cache-kubeconfig. Since all shards need to use the same cache, this means you can have exactly 1 cache server in your kcp installation.
  • No persistence: kcp currently does not allow to use an external etcd with the cache server. Instead the server will either piggyback on kcp (if it's running in-process, then it will claim the /cache key prefix in etcd to store its data) to use the embedded etcd (which does dump data to disk, but it's difficult to make this work with Deployments/StatefulSets in Kubernetes).

Nontheless, with this PR the operator at least catches up to state of the art in kcp land.

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #11

Release Notes

Add support for external cache servers using `CacheServer` objects.

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 2, 2026
@xrstf xrstf force-pushed the implement-cache-servers branch from 3212f51 to c03626e Compare February 4, 2026 09:12
@xrstf xrstf changed the title WIP - Implement cache servers Implement cache servers Feb 4, 2026
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026
@xrstf xrstf requested review from gman0 and olamilekan000 February 4, 2026 09:14
@xrstf
Copy link
Contributor Author

xrstf commented Feb 4, 2026

/retest

@xrstf xrstf force-pushed the implement-cache-servers branch 4 times, most recently from c1906a7 to 171b310 Compare February 4, 2026 10:23
@olamilekan000
Copy link
Contributor

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@olamilekan000
Copy link
Contributor

/retest

@xrstf
Copy link
Contributor Author

xrstf commented Feb 4, 2026

/lgtm cancel

This PR is not yet ready.

@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@xrstf xrstf changed the title Implement cache servers WIP - Implement cache servers Feb 4, 2026
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026
@olamilekan000
Copy link
Contributor

olamilekan000 commented Feb 4, 2026

/lgtm cancel

This PR is not yet ready.

I thought you were done 🤦

On-behalf-of: @SAP christoph.mewes@sap.com
xrstf added 11 commits February 11, 2026 14:23
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf xrstf force-pushed the implement-cache-servers branch from 357c59f to e13e406 Compare February 11, 2026 13:39
@xrstf xrstf changed the title WIP - Implement cache servers Implement cache servers Feb 11, 2026
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2026
@xrstf xrstf moved this from In Progress to In-Review in Platform Mesh & Kube Projects - Backlog Feb 12, 2026
@xrstf xrstf assigned ntnn and unassigned olamilekan000 Feb 12, 2026
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf xrstf requested a review from ntnn February 12, 2026 12:26
@xrstf
Copy link
Contributor Author

xrstf commented Feb 12, 2026

/retest

Copy link
Member

@ntnn ntnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2026
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 31712513b2d149132220cd1e24dfde202a6de234

@xrstf
Copy link
Contributor Author

xrstf commented Feb 12, 2026

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2026
@kcp-ci-bot kcp-ci-bot merged commit 8504057 into kcp-dev:main Feb 12, 2026
12 checks passed
@xrstf xrstf deleted the implement-cache-servers branch February 18, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Implement CacheServer reconciling

4 participants