Merged
Conversation
3212f51 to
c03626e
Compare
Contributor
Author
|
/retest |
c1906a7 to
171b310
Compare
Contributor
|
/lgtm |
Contributor
|
/retest |
Contributor
Author
|
/lgtm cancel This PR is not yet ready. |
Contributor
I thought you were done 🤦 |
171b310 to
357c59f
Compare
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
357c59f to
e13e406
Compare
ntnn
reviewed
Feb 11, 2026
On-behalf-of: @SAP christoph.mewes@sap.com
Contributor
Author
|
/retest |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 31712513b2d149132220cd1e24dfde202a6de234 |
Contributor
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements support for creating and reconciling a kcp cache server. It offers to the user what kcp currently offers to us: A singular cache server that cannot have meaningful persistence yet.
--cache-kubeconfig. Since all shards need to use the same cache, this means you can have exactly 1 cache server in your kcp installation./cachekey prefix in etcd to store its data) to use the embedded etcd (which does dump data to disk, but it's difficult to make this work with Deployments/StatefulSets in Kubernetes).Nontheless, with this PR the operator at least catches up to state of the art in kcp land.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #11
Release Notes