Skip to content

Restore RBAC#146

Merged
kcp-ci-bot merged 3 commits intokcp-dev:mainfrom
xrstf:restore-rbac
Feb 5, 2026
Merged

Restore RBAC#146
kcp-ci-bot merged 3 commits intokcp-dev:mainfrom
xrstf:restore-rbac

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Feb 4, 2026

Summary

#136 brazenly removed ALL of the RBAC in this repository. Sadly due to misconfiguration, the e2e tests did not run on that PR, otherwise we would have noticed sooner that this completely breaks the operator.

This PR brings back the required RBAC and makes sure that e2e tests run on config/ changes.

What Type of PR Is This?

/kind regression

Release Notes

NONE

xrstf added 3 commits February 4, 2026 14:06
This reverts commit 0619d6c.

On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/regression Categorizes issue or PR as related to a regression from a prior release. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2026
@ntnn
Copy link
Member

ntnn commented Feb 4, 2026

/lgtm
/approve

@mjudeikis ping

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 3ee47073ace8cd588a106afa30db067752340ac3

@mjudeikis
Copy link
Contributor

cleaning went too far :D sorry

@mjudeikis
Copy link
Contributor

/approve
/retest

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, ntnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2026
@ntnn
Copy link
Member

ntnn commented Feb 5, 2026

/retest

1 similar comment
@mjudeikis
Copy link
Contributor

/retest

@ntnn
Copy link
Member

ntnn commented Feb 5, 2026

Looking at the table I'm guessing we are using a token, so we have 200 pulls per 6 hours?
https://docs.docker.com/docker-hub/usage/

I would have expected that we can pull again by now =/

@mjudeikis
Copy link
Contributor

I somehow struggle to see how this could be related. Maybe just bad timing? Not the first time dockerhub changed their rate limits without notice...

@ntnn
Copy link
Member

ntnn commented Feb 5, 2026

Oh we are doing unauthenticated pulls:

You have reached your unauthenticated pull rate limit.

So 100 pulls per v6 IP per 6h. Still should be able to pull again. Unless docker resets the pull timeout on every failed pull :D

@xrstf
Copy link
Contributor Author

xrstf commented Feb 5, 2026

I'll work on the mirror today.

@mjudeikis
Copy link
Contributor

/retest
maybe? Just maybe?

@kcp-ci-bot kcp-ci-bot merged commit 8586957 into kcp-dev:main Feb 5, 2026
12 checks passed
@xrstf xrstf deleted the restore-rbac branch February 6, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants