Conversation
|
/lgtm @mjudeikis ping |
|
LGTM label has been added. DetailsGit tree hash: 3ee47073ace8cd588a106afa30db067752340ac3 |
|
cleaning went too far :D sorry |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis, ntnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
Looking at the table I'm guessing we are using a token, so we have 200 pulls per 6 hours? I would have expected that we can pull again by now =/ |
|
I somehow struggle to see how this could be related. Maybe just bad timing? Not the first time dockerhub changed their rate limits without notice... |
|
Oh we are doing unauthenticated pulls:
So 100 pulls per v6 IP per 6h. Still should be able to pull again. Unless docker resets the pull timeout on every failed pull :D |
|
I'll work on the mirror today. |
|
/retest |
Summary
#136 brazenly removed ALL of the RBAC in this repository. Sadly due to misconfiguration, the e2e tests did not run on that PR, otherwise we would have noticed sooner that this completely breaks the operator.
This PR brings back the required RBAC and makes sure that e2e tests run on
config/changes.What Type of PR Is This?
/kind regression
Release Notes