Add caBundle as backendCA for frontProxy Path ConfigMap#148
Conversation
Signed-off-by: Cyrill Berg <cyrill.berg@bwi.de>
Signed-off-by: Cyrill Berg <cyrill.berg@bwi.de>
|
Hi @BergCyrill. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
most of the code is pretty similar to the rootShard caBundleSecretRef implementation. Maybe one could implemented this to be more "DRY". Kept it this way to keep this PR "small" |
|
/label tide/merge-method-squash |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 3cba223405672316984af40d4141b74cbca3789c |
Summary
This PR adds caBundle configuration to the frontProxy ConfigMap to allow non-kcp-ca certificates for the rootShard.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #140
Release Notes