Skip to content

Add caBundle as backendCA for frontProxy Path ConfigMap#148

Merged
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
BergCyrill:bugfix/no-ref/frontProxy-caBundleSecretRef
Mar 4, 2026
Merged

Add caBundle as backendCA for frontProxy Path ConfigMap#148
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
BergCyrill:bugfix/no-ref/frontProxy-caBundleSecretRef

Conversation

@BergCyrill
Copy link
Contributor

Summary

This PR adds caBundle configuration to the frontProxy ConfigMap to allow non-kcp-ca certificates for the rootShard.

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #140

Release Notes

allow custom certificates for rootShard and frontProxy->rootShard communication

Signed-off-by: Cyrill Berg <cyrill.berg@bwi.de>
Signed-off-by: Cyrill Berg <cyrill.berg@bwi.de>
@kcp-ci-bot kcp-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2026
@kcp-ci-bot
Copy link
Contributor

Hi @BergCyrill. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2026
@BergCyrill
Copy link
Contributor Author

most of the code is pretty similar to the rootShard caBundleSecretRef implementation. Maybe one could implemented this to be more "DRY". Kept it this way to keep this PR "small"

@xrstf xrstf requested a review from mjudeikis February 25, 2026 13:08
@xrstf
Copy link
Contributor

xrstf commented Mar 4, 2026

/label tide/merge-method-squash
/ok-to-test
/approve

@kcp-ci-bot kcp-ci-bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2026
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@xrstf
Copy link
Contributor

xrstf commented Mar 4, 2026

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 3cba223405672316984af40d4141b74cbca3789c

@kcp-ci-bot kcp-ci-bot merged commit 11ec4bc into kcp-dev:main Mar 4, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: frontProxy does not support shards with non kcp-ca certificates

3 participants