Fix external hostname for root shard

[mjudeikis]

Summary

After the change:

virtualWorkspaces:
    - url: https://alpha-shard-kcp.kcp-faros.svc.cluster.local:6443/services/apiexport/36nt823y7lbbeust/tenancy.faros.sh
    - url: https://root-shard-kcp.kcp-faros.svc.cluster.local:6443/services/apiexport/36nt823y7lbbeust/tenancy.faros.sh

What Type of PR Is This?

Related Issue(s)

Fixes ##69

Release Notes

Fix root shard URL setting

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mjudeikis. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kcp-ci-bot]

@mjudeikis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kcp-operator-lint	03412d0	link	true	/test pull-kcp-operator-lint
pull-kcp-operator-test-e2e-canary	03412d0	link	false	/test pull-kcp-operator-test-e2e-canary

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[embik]

This feels wrong. So far, e.g. in the Helm chart, we've set --external-hostname to the ... well, external hostname, i.e. the public DNS entry that points to the front-proxy. Now this is a purely cluster-internal name, and these URLs won't be useful to users (and in fact leak information like the namespace).

[embik]

But I can also see from the PR description what you are trying to do. I'm confused now what this flag should be ... I wonder if we have a more general architecture problem.

[mjudeikis]

Once OIDC lands I will come back to this. Having a lot of testing in my env for these things.

[mjudeikis]

I think this is wrong too now.