Skip to content

Allow additional shards to schedule workspaces to remote shards#72

Merged
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
embik:logical-cluster-admin-shard
Jul 11, 2025
Merged

Allow additional shards to schedule workspaces to remote shards#72
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
embik:logical-cluster-admin-shard

Conversation

@embik
Copy link
Member

@embik embik commented Jul 11, 2025

Summary

Turns out that you need --logical-cluster-admin and --external-logical-cluster-admin flags on additional shards as well, because otherwise they will try to use a loopback client configuration which is not accepted by e.g. the root shard.

This generates the necessary client certs for a shard and matching kubeconfigs to mount, plus it fiddles with flags (e.g. --shard-base-url was missing) to the degree I was able to create workspaces in all directions (I think).

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes #

Release Notes

Set up necessary logical-cluster-admin kubeconfigs for additional shards

embik added 2 commits July 11, 2025 16:36
On-behalf-of: SAP <marvin.beckers@sap.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
On-behalf-of: SAP <marvin.beckers@sap.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik requested a review from mjudeikis July 11, 2025 14:40
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 11, 2025
@embik
Copy link
Member Author

embik commented Jul 11, 2025

/kind bug

@kcp-ci-bot kcp-ci-bot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 11, 2025
@mjudeikis
Copy link
Contributor

/retest

@mjudeikis
Copy link
Contributor

/lgtm
/approve
it can be worse than it is already

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 1cb2b7641647e73f3e8e38b89a4eae0aae4e6c2b

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@kcp-ci-bot kcp-ci-bot merged commit e7d5a98 into kcp-dev:main Jul 11, 2025
10 checks passed
@embik embik deleted the logical-cluster-admin-shard branch July 11, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants