Skip to content

Add virtualWorkspace & baseURL flag#73

Closed
mjudeikis wants to merge 1 commit intokcp-dev:mainfrom
mjudeikis:mjudeikis/vw.url
Closed

Add virtualWorkspace & baseURL flag#73
mjudeikis wants to merge 1 commit intokcp-dev:mainfrom
mjudeikis:mjudeikis/vw.url

Conversation

@mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Jul 12, 2025

Summary

What Type of PR Is This?

Now we need to provide baseURL for shards, as it will default to pod IP address.
While VirtualWorkspaceURL is defaulted from baseURL, I added it for consistency and readability. Easier to read and reason about. Else you see the behaviour vs flags and don't understand what is happening.

These flags converts to shard object spec hence having them makes it easier to spot inconsistencies (they happen if you change flags but dont recreate shard object)_

  spec:
    baseURL: https://root-kcp.kcp-faros.svc.cluster.local:6443
    externalURL: https://frontproxy-front-proxy.kcp-faros.svc.cluster.local:6443
    virtualWorkspaceURL: https://root-kcp.kcp-faros.svc.cluster.local:6443

/kind bug

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 12, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mjudeikis. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 12, 2025
@mjudeikis mjudeikis changed the title Add virtualWorkspace url flag Add virtualWorkspace & baseURL flag Jul 12, 2025
@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2025
@kcp-ci-bot kcp-ci-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2025
@mjudeikis mjudeikis closed this Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants