Do not validate ServiceAccount tokens at the front-proxy layer#74
Merged
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom Jul 17, 2025
Merged
Do not validate ServiceAccount tokens at the front-proxy layer#74kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
Conversation
On-behalf-of: SAP <marvin.beckers@sap.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kcp-ci-bot
added
release-note
Member
Author
|
/hold Just want to try 1-2 more things before merging this. |
kcp-ci-bot
added
the
do-not-merge/hold
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Member
Author
|
/hold cancel |
kcp-ci-bot
removed
the
do-not-merge/hold
mjudeikis
approved these changes
Jul 17, 2025
Contributor
|
LGTM label has been added. DetailsGit tree hash: 3e56c69cc254a2e2903b90b7bb4b99ee49739bee |
Member
Author
|
/retest |
2 similar comments
Contributor
|
/retest |
Contributor
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Looks like setting this flag (
--service-account-key-file) on the front-proxy is a mistake because it will validate ServiceAccount tokens only against the PKI infrastructure of the root shard for ServiceAccounts, but not against other shards.Disabling ServiceAccount validation on the front-proxy will let it pass through the request to the individual shard where it is successfully validated.
I've tested this on the kind setup and it seems to now work (i.e. ServiceAccount tokens generated for one workspace worked against the other), but I'm not 100% confident either. This should unblock using ServiceAccounts in a multi-shard environment, but further investigation might be needed (e.g. what is with cross-workspace ServiceAccounts? Afaik we support that now, but it might not be covered by the changes in this PR).
What Type of PR Is This?
/kind bug
/kind cleanup
Related Issue(s)
Fixes #
Release Notes