prealloc suddenly complained about new issues

On-behalf-of: @SAP [email protected]

Author: xrstf

cmd/sharded-test-server/main.go

@@ -216,7 +216,7 @@ func start(proxyFlags, shardFlags []string, logDirPath, workDirPath string, numb
 	}
 
 	// start shards
-	var shards []*testshard.Shard
+	shards := make([]*testshard.Shard, numberOfShards)
 	for i := range numberOfShards {
 		shard, err := newShard(ctx, i, shardFlags, standaloneVW, servingCA, hostIP.String(), logDirPath, workDirPath, cacheServerConfigPath, clientCA)
 		if err != nil {
@@ -225,7 +225,7 @@ func start(proxyFlags, shardFlags []string, logDirPath, workDirPath string, numb
 		if err := shard.Start(ctx, quiet); err != nil {
 			return err
 		}
-		shards = append(shards, shard)
+		shards[i] = shard
 	}
 
 	// Start virtual-workspace servers

pkg/virtual/framework/forwardingregistry/store_test.go

@@ -30,9 +30,9 @@ func TestUpdateToCreateOptions(t *testing.T) {
 	numField := updateOptions.NumField()
 	require.Equalf(t, 4, numField, "UpdateOptions is expected to have 4 fields")
 
-	var fields []string
+	fields := make([]string, numField)
 	for i := range numField {
-		fields = append(fields, updateOptions.Field(i).Name)
+		fields[i] = updateOptions.Field(i).Name
 	}
 
 	// Assert the UpdateOptions struct fields set has not changed

test/e2e/virtual/apiexport/virtualworkspace_test.go

@@ -1125,9 +1125,11 @@ func newCowboy(namespace, name string) *wildwestv1alpha1.Cowboy {
 }
 
 func createClusterRoleAndBindings(name, subjectName, subjectKind string, verbs []string, resources ...string) (*rbacv1.ClusterRole, *rbacv1.ClusterRoleBinding) {
-	var rules []rbacv1.PolicyRule
+	var total = len(resources) / 3
 
-	for i := range len(resources) / 3 {
+	rules := make([]rbacv1.PolicyRule, total)
+
+	for i := range total {
 		group := resources[i*3]
 		resource := resources[i*3+1]
 		resourceName := resources[i*3+2]
@@ -1142,7 +1144,7 @@ func createClusterRoleAndBindings(name, subjectName, subjectKind string, verbs [
 			r.ResourceNames = []string{resourceName}
 		}
 
-		rules = append(rules, r)
+		rules[i] = r
 	}
 
 	return &rbacv1.ClusterRole{