Skip to content

🌱 Fix flaky SA test #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcp-ci-bot merged 1 commit into from
Feb 22, 2025
Merged

🌱 Fix flaky SA test #3290

kcp-ci-bot merged 1 commit into from
Feb 22, 2025

Conversation

@mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Feb 9, 2025 •
edited
Loading

Summary

Fix flaky test by disabling lookups

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2025
@mjudeikis mjudeikis changed the title 🌱 Disable flaky test 🌱 Disable flaky SA test Feb 9, 2025
@mjudeikis
Copy link
Contributor Author

mjudeikis commented Feb 9, 2025

/retest all

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Feb 9, 2025

@mjudeikis: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /build-image
  • /test pull-kcp-build-image
  • /test pull-kcp-lint
  • /test pull-kcp-test-e2e
  • /test pull-kcp-test-e2e-multiple-runs
  • /test pull-kcp-test-e2e-sharded
  • /test pull-kcp-test-e2e-shared
  • /test pull-kcp-test-unit
  • /test pull-kcp-validate-prow-yaml
  • /test pull-kcp-verify
  • /test pull-kcp-verify-codegen

Use /test all to run the following jobs that were automatically triggered:

  • pull-kcp-build-image
  • pull-kcp-lint
  • pull-kcp-test-e2e
  • pull-kcp-test-e2e-multiple-runs
  • pull-kcp-test-e2e-sharded
  • pull-kcp-test-e2e-shared
  • pull-kcp-test-unit
  • pull-kcp-validate-prow-yaml
  • pull-kcp-verify
  • pull-kcp-verify-codegen
Details

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjudeikis
Copy link
Contributor Author

mjudeikis commented Feb 9, 2025

/test all

2 similar comments
@mjudeikis
Copy link
Contributor Author

mjudeikis commented Feb 9, 2025

/test all

@mjudeikis
Copy link
Contributor Author

mjudeikis commented Feb 10, 2025

/test all

@sttts
Copy link
Member

sttts commented Feb 10, 2025

/hold

Don't think this is what we want.

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
@embik
Copy link
Member

embik commented Feb 10, 2025

Just for cross-ref, this is is related to #3274 and #3289, I think.

@mjudeikis mjudeikis force-pushed the mjudeikis/disble.flaky.test branch from 5711b70 to a0b69b8 Compare February 14, 2025 14:54
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2025
@mjudeikis mjudeikis changed the title 🌱 Disable flaky SA test 🌱 Fix flaky SA test Feb 14, 2025
@mjudeikis
Copy link
Contributor Author

mjudeikis commented Feb 14, 2025

/test all

2 similar comments
@mjudeikis
Copy link
Contributor Author

mjudeikis commented Feb 14, 2025

/test all

@mjudeikis
Copy link
Contributor Author

mjudeikis commented Feb 15, 2025

/test all

@mjudeikis mjudeikis force-pushed the mjudeikis/disble.flaky.test branch from a0b69b8 to 9b58b2f Compare February 20, 2025 19:24
@mjudeikis
Copy link
Contributor Author

mjudeikis commented Feb 20, 2025

/test all

1 similar comment
@mjudeikis
Copy link
Contributor Author

mjudeikis commented Feb 20, 2025

/test all

@sttts
Copy link
Member

sttts commented Feb 22, 2025

/hold cancel
/lgtm
/approve

@kcp-ci-bot kcp-ci-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2025
@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Feb 22, 2025

LGTM label has been added.

DetailsGit tree hash: 9f0040c2e3541c4a6097721fcb7f94906ee389bf

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Feb 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2025
@kcp-ci-bot kcp-ci-bot merged commit 9e20867 into kcp-dev:main Feb 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mjudeikis @kcp-ci-bot @sttts @embik