🌱 Pin GitHub Actions workflows to commits#3354
Merged
kcp-ci-bot merged 3 commits intokcp-dev:mainfrom Mar 27, 2025
Merged
Conversation
kcp-ci-bot
added
release-note-none
On-behalf-of: SAP <marvin.beckers@sap.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
On-behalf-of: SAP <marvin.beckers@sap.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
embik
force-pushed
the
pin-github-workflows
branch
from
2ea9590 to
7204a48
Compare
xrstf
reviewed
Mar 26, 2025
On-behalf-of: SAP <marvin.beckers@sap.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
embik
force-pushed
the
pin-github-workflows
branch
from
c51e3d2 to
58c534a
Compare
Contributor
|
LGTM label has been added. DetailsGit tree hash: 7323134ca451ebfd73a261b8f8288d032ae7f5be |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It's a best practice to pin workflows used in GitHub Actions to specific commits. We should do that.
In addition, I feel like our dependabot configuration doesn't work (is it maybe not enabled?), so I'm copying the one we are using in kubernetes-sigs/multicluster-runtime.
Related issue(s)
Fixes #
Release Notes