Skip to content

Use staging repositories in our go.mod files #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 8, 2025
Merged

Use staging repositories in our go.mod files #3638

merged 8 commits into from
Oct 8, 2025

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Oct 8, 2025 •
edited
Loading

Summary

This adds the necessary replace directives to begin using our staged repositories.

For now, this PR excludes the staging modules from linting and boilerplate checking. We'll fix those later, for now we just want to unblock progress.

cc @ntnn This also fixes the "eel.dev" you introduced randomly in #3511. 😁

What Type of PR Is This?

/kind cleanup

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has signed the DCO. area/cli Issues or PRs related to CLI changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2025
embik added 5 commits October 8, 2025 16:45
@embik
Ignore staging/src in boilerplate check for now
344ec34 
On-behalf-of: SAP <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
@embik
Copy staging repository go.mod files into early build stage
fe51031 
On-behalf-of: SAP <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
@embik
Fix linting issues in github.com/kcp-dev/apimachinery staging repository
f7cc233 
On-behalf-of: SAP <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
@embik
Fix linting issues in github.com/kcp-dev/client-go staging repository
1801676 
On-behalf-of: SAP <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
@embik
Skip staging repository linting for now
7ef8480 
On-behalf-of: SAP <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2025
@embik
Fix imports across staging repositories
218f32b 
On-behalf-of: SAP <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
@kcp-ci-bot kcp-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2025
embik
embik approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 8, 2025

LGTM label has been added.

Git tree hash: 834a08c6957fbca81d60c562b74e2dd780b5252b

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@gman0
Copy link
Contributor

gman0 commented Oct 8, 2025 •
edited
Loading

/retest

panic: test timed out after 10m0s
	running tests:
		TestAPIBinding (41s)
		TestAPIBindingAPIExportReferenceImmutability (39s)
		TestAPIBindingLogicalCluster (16s)

https://public-prow.kcp.k8c.io/view/s3/prow-public-data/pr-logs/pull/kcp-dev_kcp/3638/pull-kcp-test-e2e-multiple-runs/1975951302290575360

@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2025
@kcp-ci-bot kcp-ci-bot requested a review from embik October 8, 2025 17:23
@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 8, 2025

LGTM label has been added.

Git tree hash: 701fe7a7f3b5bd8f65119a5cec6a77208c384d1d

@kcp-ci-bot kcp-ci-bot merged commit d7c8e22 into kcp-dev:main Oct 8, 2025
14 checks passed
@embik embik mentioned this pull request Oct 9, 2025
Open
6 tasks
@xrstf xrstf deleted the use-staging-repos branch November 4, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Issues or PRs related to CLI changes dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xrstf @kcp-ci-bot @gman0 @embik