-
Notifications
You must be signed in to change notification settings - Fork 424
adds doc suggestions made on issue 3666 #3668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RobertKielty
wants to merge
1
commit into
kcp-dev:main
Choose a base branch
from
RobertKielty:3666
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,14 @@ | ||
| # Built-in APIs | ||
| # Kubernetes API Endpoints used by kcp | ||
|
|
||
| kcp includes some, but not all, of the APIs you are likely familiar with from Kubernetes: | ||
| kcp includes some, but not all, of the Kubernetes APIs. | ||
|
|
||
| ## (core) v1 | ||
| kcp does not make us of Kubernetes API endpoints that are concerned with orchestrating clusters and their workloads. Clusters dedicated to workload orchestration have these resources but kcp does not. | ||
|
|
||
| ## Kubernetes resources used by kcp | ||
|
|
||
| kcp makes use of these API Endpoints and resources to provide kcp features and indoing so leverages the Kubernetes Event Loop to manage non-cluster resources that can them be handles using conventions and tooling from the Kubernetes eco-system. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This sentence sounds strange. Do we even need this if we detalized above? |
||
|
|
||
| ### (core) v1 | ||
| - Namespaces | ||
| - ConfigMaps | ||
| - Secrets | ||
|
|
@@ -11,43 +17,40 @@ kcp includes some, but not all, of the APIs you are likely familiar with from Ku | |
| - ResourceQuotas | ||
| - ServiceAccounts | ||
|
|
||
| ## admissionregistration.k8s.io/v1 | ||
| ### admissionregistration.k8s.io/v1 | ||
| - MutatingWebhookConfigurations | ||
| - ValidatingWebhookConfigurations | ||
| - ValidatingAdmissionPolicies | ||
| - ValidatingAdmissionPolicyBindings | ||
|
|
||
| ## apiextensions.k8s.io/v1 | ||
| ### apiextensions.k8s.io/v1 | ||
| - CustomResourceDefinitions | ||
|
|
||
| ## authentication.k8s.io/v1 | ||
| ### authentication.k8s.io/v1 | ||
| - TokenReviews | ||
|
|
||
| ## authorization.k8s.io/v1 | ||
| ### authorization.k8s.io/v1 | ||
| - LocalSubjectAccessReviews | ||
| - SelfSubjectAccessReviews | ||
| - SelfSubjectRulesReviews | ||
| - SubjectAccessReviews | ||
|
|
||
| ## certificates.k8s.io/v1 | ||
| ### certificates.k8s.io/v1 | ||
| - CertificateSigningRequests | ||
|
|
||
| ## coordination.k8s.io/v1 | ||
| ### coordination.k8s.io/v1 | ||
| - Leases | ||
|
|
||
| ## events.k8s.io/v1 | ||
| ### events.k8s.io/v1 | ||
| - Events | ||
|
|
||
| ## flowcontrol.apiserver.k8s.io/v1beta1 (temporarily removed) | ||
| ### flowcontrol.apiserver.k8s.io/v1beta1 (temporarily removed) | ||
| - FlowSchemas | ||
| - PriorityLevelConfigurations | ||
|
|
||
| ## rbac.authorization.k8s.io/v1 | ||
| ### rbac.authorization.k8s.io/v1 | ||
| - ClusterRoleBindings | ||
| - ClusterRoles | ||
| - RoleBindings | ||
| - Roles | ||
|
|
||
| Notably, workload-related APIs (Pods, ReplicaSets, Deployments, Jobs, CronJobs, StatefulSets), cluster-related APIs ( | ||
| Nodes), storage-related APIs (PersistentVolumes, PersistentVolumeClaims) are all missing - kcp does not include these, | ||
| and it instead relies on workload clusters to provide this functionality. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sounds bit of strange too.
I think we need to be more explicit: