CachedResources: replicate full objects #3683
Conversation
kcp-ci-bot
added
release-note-none
| localExists := !apierrors.IsNotFound(err) | ||
|
|
||
| // we only replicate objects that match the label selector. | ||
| if localExists && r.localLabelSelector != nil && !r.localLabelSelector.Matches(labels.Set(localCopy.GetLabels())) { |
There was a problem hiding this comment.
This early-return with selector mismatch is an additional opportunity to optimize away the GET call: we could feed r.getLocalCopy with the selector, and skip on mismatch before getting the full object.
Let me know if you'd like to do it still in this PR or separately.
There was a problem hiding this comment.
Lets do that, and rename the function so its something clearer names what it actually does now
|
/retest |
| }, | ||
| } | ||
| // r.getLocalCopy is defined separately because it calls r.getGlobalCopy internally. | ||
| r.getLocalCopy = func(cluster logicalcluster.Name, namespace, name string) (*unstructured.Unstructured, error) { |
There was a problem hiding this comment.
Name now does now make sense. Can we rename to something better as it calls both now?
gman0
force-pushed
the
cachedresources-fix-getlocalcopy
branch
from
e614097 to
41fb874
Compare
gman0
changed the title
gman0
force-pushed
the
cachedresources-fix-getlocalcopy
branch
from
428f555 to
cc73264
Compare
|
/retest |
kcp-ci-bot
added
the
needs-rebase
…urce CachedResource Each instance of the replication controller is dedicated to a specific CachedResource object, and so its CachedObjects handler should only react on objects that are coming from that CachedResource. On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
DDSIF, the informer for retrieving local objects, yields only PartialMetadataObjects. This commit adds a live GET call to retrieve the full object for replication. On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
gman0
force-pushed
the
cachedresources-fix-getlocalcopy
branch
from
cc73264 to
a56886f
Compare
kcp-ci-bot
removed
the
needs-rebase
| } | ||
|
|
||
| // Skip CachedObjects that are not coming from the source CachedResource. | ||
|
|
There was a problem hiding this comment.
nit: dont need these new lines :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: eca7d391de255e7b5579f711971ef735084b820a
|
kcp-ci-bot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
4 participants
Summary
DDSIF, the informer for retrieving local objects, yields only PartialMetadataObjects. This PR adds a live GET call to retrieve the full object for replication.
What Type of PR Is This?
/kind bug
Related Issue(s)
Fixes #3478
Release Notes