Bump golangci-lint to 2.6.0 #3688
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note-none
kcp-ci-bot
added
the
needs-rebase
On-behalf-of: @SAP [email protected]
xrstf
force-pushed
the
go125-lint-compat
branch
from
65a30ca to
c05d4d7
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
removed
the
needs-rebase
On-behalf-of: @SAP [email protected]
xrstf
force-pushed
the
go125-lint-compat
branch
from
c05d4d7 to
47b97da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is just maintenance. I also bumped logcheck because 0.9 doesn't work on Go 1.25 systems.
gocritic now complains about the misplaced Deprecation notices, and after fixing them, I had to adjust a bit of code in our codebase. However I did not remove the deprecated CreateSheriff, even though it was meant to be deprecated allll the way back in #1642 (2022). But since that never worked, nobody noticed and so I would declare today the official deprecation day 😁
What Type of PR Is This?
/kind chore
Release Notes