Don't override RV when listing in Replication VW #3689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
kcp-ci-bot
added
release-note-none
|
/retest |
Now that CachedObjects embeds the real resource version of the original object, the unwrappingWatch in Replication VW should check against that RV when handling ADDED events. On-behalf-of: @SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
kcp-ci-bot
added
size/S
|
/retest |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 45f48f1dd1eb7720e407726ec245eef89f0c6edf
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The listing function in Replication VW sets a synthetic resource version on each item when constructing the list. This was done before CachedObjects had the RVs of their original objects set, and we needed at least some RV.
Now that real RVs are being set on CachedObjects, the Repl VW should use them.
What Type of PR Is This?
/kind bug
Release Notes