add unit tets for GeneratePatchAndSubResources #3773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: SAP <[email protected]> Signed-off-by: Simon Bein <[email protected]>
kcp-ci-bot
added
dco-signoff: yes
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
|
/retest |
Contributor
|
/approve |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 1b5fcc2fdf709678d786cce91870a1e4f2f81512 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Contributor
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just used LogicalClusters in unit-testing. Compared to the original issue, I have decided to not to also test
withPatchAndSubResources, as this just calls generatePatchAndSubResources with a passed in patch func and therefore does not really benefit from unit testing.Summary
What Type of PR Is This?
/kind cleanup
Related Issue(s)
Fixes: #3426
Release Notes