Merged
Conversation
Contributor
Author
|
This is early, want to see how much of things breaks |
09845dc to
da38f54
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
/test all |
Contributor
|
LGTM label has been added. DetailsGit tree hash: f16a182d2a34870ce542d2ca2f8acfa7626630fb |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: strip scopes from ServiceAccount tokens in maximal permission policy check
What Type of PR Is This?
/kind bug
Fix 403 Forbidden when ServiceAccount accesses claimed resources via APIExport virtual workspace
Strip scope-related Extra fields only for ServiceAccounts in maximal permission policy authorizer
Add e2e test to prevent regression
When an APIExport includes a permissionClaim on resources from another APIExport (e.g., tenancy.kcp.io/workspaces), and a consumer accepts that claim in an APIBinding, the provider's ServiceAccount receives a 403 Forbidden when accessing the claimed resources via the APIExport virtual workspace—even though it has proper apiexports/content RBAC.
Root Cause
ServiceAccount tokens are scoped to their originating workspace (e.g., cluster:root:org:provider). When accessing claimed resources, the maximal permission policy check runs in the workspace where the claimed APIExport lives (e.g., root for tenancy.kcp.io). The deep SubjectAccessReview fails because the SA token's scope doesn't include the target workspace.
Solution
Strip scope-related Extra fields (authentication.kcp.io/scopes and authentication.kcp.io/cluster-name) from ServiceAccounts only in prefixAttributes() before running the maximal permission policy check.
This is safe because:
Related Issue(s)
Fixes #3840
Release Notes