Skip to content

Bump golangci-lint to v2.10.1#3874

Merged
kcp-ci-bot merged 4 commits intokcp-dev:mainfrom
ntnn:bum-golangci-lint
Mar 3, 2026
Merged

Bump golangci-lint to v2.10.1#3874
kcp-ci-bot merged 4 commits intokcp-dev:mainfrom
ntnn:bum-golangci-lint

Conversation

@ntnn
Copy link
Member

@ntnn ntnn commented Mar 2, 2026

Summary

I have updated to go1.26 and that seems to be causing issues when running golangci-lint in (at least) 2.6.0.

Changes:

  1. Applied preallocs where it made sense
  2. Ignored preallocs where it didn't make sense (and could easily be overlooked in the future)
  3. Ignored gosec in a few places where the finding is valid but not in that context
  4. Disabled the taint analysis, there seems to be a problem in the currently used version with the taint analysis not working at all

Otherwise just applied linter findings.

What Type of PR Is This?

/kind cleanup

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2026
@ntnn ntnn force-pushed the bum-golangci-lint branch 3 times, most recently from 532ac41 to 4917713 Compare March 2, 2026 15:10
@kcp-ci-bot kcp-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2026
@ntnn ntnn force-pushed the bum-golangci-lint branch 2 times, most recently from 3270284 to 8a2a7f2 Compare March 2, 2026 19:53
@ntnn
Copy link
Member Author

ntnn commented Mar 2, 2026

/retest

@ntnn ntnn force-pushed the bum-golangci-lint branch from 432afe4 to 1ddd29e Compare March 2, 2026 21:22
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 2, 2026
ntnn added 4 commits March 2, 2026 22:46
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn ntnn force-pushed the bum-golangci-lint branch from 1ddd29e to 2792a7e Compare March 2, 2026 21:46
@ntnn
Copy link
Member Author

ntnn commented Mar 2, 2026

/test pull-kcp-test-e2e-sharded

Copy link
Contributor

@mjudeikis mjudeikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 03f2a5d6b9c8731b745642d609c83d2caa085cfa

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@ntnn ntnn assigned ntnn and mjudeikis and unassigned mjudeikis Mar 3, 2026
@kcp-ci-bot kcp-ci-bot merged commit 4e73ead into kcp-dev:main Mar 3, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants