[DIFF] kcp-1.33.3 #170
Closed
[DIFF] kcp-1.33.3 #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]> Co-authored-by: Marvin Beckers <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
Partially reverting e8b1d7d. kcp's GC controller is event-based for now, and without locks we may miss events during monitor syncs. There are known issues that locking causes: * kubernetes#101078 * kubernetes#127105 On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
…_quota_controller_patch.go
Ran:
go run ./hack/kcp/resource_quota_controller_patch.go > pkg/controller/resourcequota/resource_quota_controller_kcp.go
and modified the resulting file so that imports are in place, and changed
the main wait.UntilWithContext loop into a closure, so that when UpdateMonitors
is called, updating is done exactly once.
On-behalf-of: SAP [email protected]
Signed-off-by: Robert Vasek <[email protected]>
…gecollector_patch.go
Ran:
go run ./hack/kcp/garbage_collector_patch.go > pkg/controller/garbagecollector/garbagecollector_kcp.go
and modified the resulting file so that imports are in place, and changed
the main wait.UntilWithContext loop into a closure, so that when ResyncMonitors
is called, syncing is done exactly once.
On-behalf-of: SAP [email protected]
Signed-off-by: Robert Vasek <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]> Signed-off-by: Marvin Beckers <[email protected]> Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]> Co-authored-by: Marvin Beckers <[email protected]> Signed-off-by: Marvin Beckers <[email protected]> Co-authored-by: Robert Vasek <[email protected]> Signed-off-by: Robert Vasek <[email protected]>
…gin and policy plugin framework Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
…rge patch Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]> Signed-off-by: Marvin Beckers <[email protected]> Signed-off-by: Dr. Stefan Schimanski <[email protected]>
…ss identities Signed-off-by: Dr. Stefan Schimanski <[email protected]>
…card partial metadata requests Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]> Signed-off-by: Marvin Beckers <[email protected]> Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]> Signed-off-by: Marvin Beckers <[email protected]> Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
… storage paths Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]> Signed-off-by: Marvin Beckers <[email protected]> Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]> Signed-off-by: Marvin Beckers <[email protected]> Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]> Signed-off-by: Marvin Beckers <[email protected]> Signed-off-by: Dr. Stefan Schimanski <[email protected]>
… control plane Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
…dler patch Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
…ilder Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
…in webhooks On-behalf-of: @SAP [email protected]
Signed-off-by: Mangirdas Judeikis <[email protected]> On-behalf-of: SAP [email protected]
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
…n and policy plugin framework On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
TODO: this commit may be dropped once kcp-dev/kcp#3274 and related issues are done Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected] Signed-off-by: Nelo-T. Wallus <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]> Signed-off-by: Dr. Stefan Schimanski <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
kcp doesn't implement protobuf codec yet, and so we need to disable it in the client code. This commit comments out --prefers-protobuf command line flag when invoking client-gen in update-codegen.sh scripts in various places. TODO: revert once kcp gains protobuf support. On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
Signed-off-by: Nelo-T. Wallus <[email protected]>
In kubernetes#130349 for KEP-5073 validation-gen was added to `gen_helpers`. KCP is currently not using validation-gen, but it is causing errors as validation-gen directly imports k8s.io/apimachinery, which is rewritten in the go.mod to `../apimachinery`. This is working fine locally and in go workspaces, but breaks as soon as `k8s.io/code-generator` is used from the kcp-dev/kubernetes fork, as then the rewrite still exists but points to nothing. Upstream the rewrites are resolved to the respective commit in the module when publishing the changes to their repositories. Signed-off-by: Nelo-T. Wallus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For kcp-dev/kcp#3511