-
Notifications
You must be signed in to change notification settings - Fork 8
Use multicluster.Aware in provider.Start function signature #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
/hold for discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 0b84ba0deb74a1be1baa673cd74d0178978d784c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We turned out to use the mcmanager after all, so this PR might not be needed anymore. |
/close for now. We will probably implement something similar once kubernetes-sigs/multicluster-runtime#62 is merged. |
@embik: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
This is not necessarily something to merge, more of a RFC. I realized we were only using
Engage
in the provider startup, and it seemed to me it would be a nice idea to usemulticluster.Aware
instead of the wholemcmanager.Manager
kitchen sink. This way, you can use the provider in more custom scenarios (in specific, @xrstf and I are currently re-thinking the api-syncagent to move it to multicluster-runtime, and we might not even use themcmanager.Manager
directly).Any thoughts on this?
What Type of PR Is This?
/kind cleanup
/kind api-change
Related Issue(s)
Fixes #
Release Notes