mkfs: use BTRFS_IOC_GET_CSUMS if available#1096
Open
maharmstone wants to merge 1 commit intokdave:develfrom
Open
mkfs: use BTRFS_IOC_GET_CSUMS if available#1096maharmstone wants to merge 1 commit intokdave:develfrom
maharmstone wants to merge 1 commit intokdave:develfrom
Conversation
Use the new BTRFS_IOC_GET_CSUMS ioctl when doing mkfs.btrfs --rootdir if it's available and the csum algorithms match, so we can use the values on disk rather than spending time recomputing them. For the case when we're also using --reflink, this means that we can now forgo reading the data entirely. Signed-off-by: Mark Harmstone <mark@harmstone.com>
adam900710
reviewed
Mar 24, 2026
| fi.flags = BTRFS_FS_INFO_FLAG_CSUM_INFO; | ||
|
|
||
| if (ioctl(source->fd, BTRFS_IOC_FS_INFO, &fi) == 0 && | ||
| fi.csum_type == root->fs_info->csum_type) |
Collaborator
There was a problem hiding this comment.
We need to check not only the csum type but also the block size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new BTRFS_IOC_GET_CSUMS ioctl when doing mkfs.btrfs --rootdir if it's available and the csum algorithms match, so we can use the values on disk rather than spending time recomputing them.
For the case when we're also using --reflink, this means that we can now forgo reading the data entirely.