Conversation
fastrand is a much lighter dependency than getrandom. We don't actually need "good" random numbers, so fastrand is perfectly adequate.
Since we're using fastrand now, we can seed the RNG, allowing us to test the exact path of the produced crash log instead of having to ignore it.
kdkasad
added
the
code cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't need secure RNG, we can use the lighter
fastrandcrate, which has fewer dependencies. It also allows us to make the integration tests deterministic, as we can seed the PRNG to control the path of the crash log file.