Conversation
Test Results41 tests 41 ✅ 0s ⏱️ Results for commit 72e2293. |
There was a problem hiding this comment.
Pull Request Overview
Refactor to use &str instead of &[u8] for the code parameter across rules, helpers, tests, and the main application.
- Updated
Rule::checksignatures and callsites to accept&str. - Removed redundant UTF-8 conversions, using direct slicing or
.as_bytes()where needed. - Adjusted all test cases and helper functions to pass
&str.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/rules/rule12a.rs | Updated check signature and test helper invocation to &str. |
| src/rules/rule11e.rs | Updated check signature to accept &str. |
| src/rules/rule11b.rs | Removed UTF-8 conversion, updated signature, and tests. |
| src/rules/rule11a.rs | Removed UTF-8 conversion, updated signature, and tests. |
| src/rules/rule03f.rs | Changed check signature to accept &str. |
| src/rules/rule03e.rs | Changed signature and removed UTF-8 conversion. |
| src/rules/rule03d.rs | Signature changes, replaced UTF-8 conversions, updated slicing. |
| src/rules/rule03c.rs | Signature change and updated byte comparisons. |
| src/rules/rule03b.rs | Signature change and updated spacing helper. |
| src/rules/rule03a.rs | Signature change and updated message formatting. |
| src/rules/rule02b.rs | Signature change and test updates. |
| src/rules/rule02a.rs | Signature change, removed UTF-8 conversions, updated helper. |
| src/rules/rule01d.rs | Signature change and updated error message slicing. |
| src/rules/rule01c.rs | Signature change, replaced utf8_text with slicing. |
| src/rules/rule01b.rs | Signature change. |
| src/rules/rule01a.rs | Signature change and slicing in suggestions. |
| src/rules/api.rs | Updated Rule trait signature. |
| src/main.rs | Updated invocation of rule.check to pass &code. |
| src/helpers/testing.rs | Updated QueryHelper::new invocation to accept &str. |
| src/helpers/mod.rs | Changed QueryHelper::new signature and code storage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10.