-
Notifications
You must be signed in to change notification settings - Fork 528
Fix Accessibility Violations for Social Media Buttons #1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
Signed-off-by: huangkevin-apr <[email protected]>
e6a99c5 to
c73d400
Compare
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Resolves accessibility violations for icon-only social media links by adding accessible names via aria-label in the social buttons partial (Fixes #1699).
Changes:
- Add
aria-labelto social button<a>elements using the existing.namefield.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]>
|
Thanks a lot for the report and the fix! |
Summary
This PR resolves 3 accessibility violations detected by the IBM Equal Access Accessibility Checker in the social buttons component. The fix adds accessible names to icon-only links by leveraging existing button data, ensuring screen reader users can identify the purpose of each social media button.

Why is this important?
When the purpose of a link is clear users can easily navigate links on the page without having to see the surrounding information for context.
Solution
Added
aria-labelattribute to the button links, utilizing the existing name property from the data structure:Why This Solution Is Elegant
This fix is particularly well-designed because it:
Leverages existing data: Uses the name property already present in the button configuration
Scales automatically: Any new social buttons added to the data will automatically have accessible names
Requires minimal changes: Single-line modification fixes all button instances
Maintains consistency: All buttons use the same accessibility pattern
No duplication: Doesn't require hard-coding labels for each button type
Checklist
Fixes #1699