fix(datasets): default plotly.JSONDataset save encoding to UTF-8
#1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hiya @SRIKAR-8-77 thanks for your contribution! A couple things CI related before I tag more people for reviews:
Could you get the CI tests passing while we review the PR? Thanks!! |
deepyaman
changed the title
plotly.JSONDataset save encoding to UTF-8
Contributor
|
Hi @SRIKAR-8-77 could you also fix the DCO test here? |
Contributor
|
@SRIKAR-8-77 Could you fix the DCO sign off on this PR too so I can make further changes? :) |
merelcht
force-pushed
the
fix-plotly-utf8
branch
from
28ed5f5 to
83f09a4
Compare
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Member
|
I've updated the test to reflect these changes and also added the change to the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #741.
The plotly.JSONDataset lacks a file encoding on save, resulting in a UnicodeDecodeError when reloading charts containing special characters on non-UTF-8 systems.
This PR resolves the bug by modifying the DEFAULT_FS_ARGS class attribute on line 55 to add encoding="utf-8" by default for save operations. This makes the save action consistent with the current utf-8 decode on load to provide consistent reliability.