Skip to content

Delete extraneous workflow to check dep resolution#5380

Merged
deepyaman merged 3 commits intomainfrom
deepyaman-patch-3
Feb 25, 2026
Merged

Delete extraneous workflow to check dep resolution#5380
deepyaman merged 3 commits intomainfrom
deepyaman-patch-3

Conversation

@deepyaman
Copy link
Member

@deepyaman deepyaman commented Feb 17, 2026

Description

There's no reason to check that you can compile Kedro's requirements (especially given we're not doing anything with the result); any of the uv installation commands is already checking that they can be resolved.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@deepyaman deepyaman marked this pull request as ready for review February 17, 2026 13:19
@deepyaman deepyaman requested a review from merelcht as a code owner February 17, 2026 13:19
@deepyaman deepyaman enabled auto-merge (squash) February 17, 2026 13:20
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember this correctly - this exists for checking the downstream dependencies changes (i.e. if CI suddenly fail then looking at the CI history you may find for example pandas 2.0.1 was passing while 2.1.0 is failing).

@deepyaman
Copy link
Member Author

If I remember this correctly - this exists for checking the downstream dependencies changes (i.e. if CI suddenly fail then looking at the CI history you may find for example pandas 2.0.1 was passing while 2.1.0 is failing).

Hmm, I don't see why it's necessary to have 4 more checks running just for this, when you can figure out what got resolved from "Install dependencies" in the CI workflow (seems like the uv pip freeze there is not working correctly).

@noklam
Copy link
Contributor

noklam commented Feb 17, 2026

I am not sure either as I didn't look into CI for a while. This was way back before uv even exist, at the time the workflows looks different. I agree this could be removed now but I think I will leave people who actively maintain the repo to decide.

@rashidakanchwala rashidakanchwala self-requested a review February 18, 2026 06:34
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepyaman... makes sense. I was also wondering earlier why pip freeze wasn’t working earlier, I have opened a PR (#5385) to fix it.

Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, I always check the result of the uv pip freeze anyway.

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Delete extraneous workflow to check dep resolution

Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman merged commit 5ed5a6d into main Feb 25, 2026
25 checks passed
@deepyaman deepyaman deleted the deepyaman-patch-3 branch February 25, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants