Delete extraneous workflow to check dep resolution#5380
Conversation
noklam
left a comment
There was a problem hiding this comment.
If I remember this correctly - this exists for checking the downstream dependencies changes (i.e. if CI suddenly fail then looking at the CI history you may find for example pandas 2.0.1 was passing while 2.1.0 is failing).
Hmm, I don't see why it's necessary to have 4 more checks running just for this, when you can figure out what got resolved from "Install dependencies" in the CI workflow (seems like the |
|
I am not sure either as I didn't look into CI for a while. This was way back before |
rashidakanchwala
left a comment
There was a problem hiding this comment.
Thanks @deepyaman... makes sense. I was also wondering earlier why pip freeze wasn’t working earlier, I have opened a PR (#5385) to fix it.
ankatiyar
left a comment
There was a problem hiding this comment.
Makes sense to me, I always check the result of the uv pip freeze anyway.
08b1bb9 to
64cff8e
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Delete extraneous workflow to check dep resolution Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
64cff8e to
11e400b
Compare
Description
There's no reason to check that you can compile Kedro's requirements (especially given we're not doing anything with the result); any of the uv installation commands is already checking that they can be resolved.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile