This repository was archived by the owner on May 22, 2023. It is now read-only.
Improvements of the signing CLI #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the output file is specified, we should not write decrypted key shares to stdout.
Merged
Shadowfiend
reviewed
Oct 2, 2020
| err = app.Run(os.Args) | ||
| if err != nil { | ||
| logger.Fatal(err) | ||
| fmt.Print(err) |
Contributor
There was a problem hiding this comment.
☀️
No rush, but we should make this change to keep-core as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR which addresses the remaining non-blocking comments of #566