Migrated to Open Zeppelin Test Environment and improved tests #97
Conversation
…nvironment Dependencies to run tests with open zeppelin test environemnt.
OZ expects tests stubs in contracts directory.
Updated tests to be able to run on OZ test env. Also included couple of improvements to tests.
There are work distribution tests that require longer timeout to be set. It may be quite cumbersome for local development, so we also added a command that will execute quick tests excluding the work distribution test: `npm run test:quick`
|
In #93 we added a possibility to Is there any way to make it work with OZ test environment? My understanding is that it's not. In this context, I am not sure what's better - OpenZeppelin test environment or buidler-vm with logging. Don't have any data regarding performance and stability to compare them though. |
| "ganache": "echo 'GANACHE IS NO LONGER USED; use buidler-vm script instead'", | ||
| "buidler-vm": "buidler node", | ||
| "buidler-vm:log": "buidler node | grep '^ \\|console.log'", |
There was a problem hiding this comment.
If we decide to sacrifice console.log functionality and move to OpenZeppelin test environment, we probably no longer need those lines.
|
We were able to merge #96 and #89 without this change. I looked at the performance comparison locally and it takes 13 minutes to execute tests on |
|
We are now on Hardhat test env, see #127. Closing without merging. |
In this PR we migrate to Open Zeppelin's Test Environment as we already did in
keep-core(threshold-network/keep-core#1528) andkeep-ecdsa(keep-network/keep-ecdsa#501).We also had to set long timeout for test runner to be able to complete
workDistributionTest.js. To balance long time execution we added a command that let's a developer to run quick test suite, excluding the distribution test:npm run test:quick.Closes #88