fix(generate-pie): infer zero-price resource bounds as fee-free - #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Teach SNOS replay to classify v3 transactions with zero max-price resource bounds as fee-free.
Why
Madara bootstrap transactions can carry nonzero resource amounts for execution while using zero prices to represent a fee-free setup transaction. Without this, SNOS asks Blockifier to charge fees and replay fails before Starknet OS execution.
Validation
The dependent Madara PR passed the sequencer-mode bridge e2e workflow with SNOS fees enabled and this revision pinned.